fix(tasks): don't wrap reminders into the past when repeating from current date - #3547
Merged
Conversation
…rrent date Offsets between reminders spanning more than ~292 years overflowed time.Duration, so the shifted reminder landed centuries in the past. Shift dates via a helper that falls back to year arithmetic when time.Time.Sub saturates, and stop sorting the reminders in place.
kolaente
enabled auto-merge (rebase)
August 18, 2026 11:27
github-actions
Bot
added
area/recurring-tasks
Preview DeploymentPreview deployments for this PR are available at:
The preview environment will start automatically on first visit. Subsequent pushes to this PR will update the Run locally with Dockerdocker pull ghcr.io/go-vikunja/vikunja:pr-3547
docker run -p 3456:3456 ghcr.io/go-vikunja/vikunja:pr-3547Last updated for commit f0149ef |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeat-from-current-date tasks with reminders more than ~292 years apart got a reminder shifted centuries into past (1744 instead of 2036).
time.Time.Subsaturatestime.DurationatMaxInt64, adding repeat interval overflowed negative. Also drops in-placesort.Slicethat reordered reminders on aliased slice.How to verify
repeat_after=315360000,repeat_mode=2and reminders1734-01-01T00:00:00Zand2026-01-01T00:00:00Z.POST /api/v1/tasks/{id}with{"done":true}and refetch it.Before this PR: the second reminder was persisted around 1744 and the reminders came back reordered.