feat(a11y): keyboard-accessible task glance tooltip - #3566
Merged
Conversation
…Escape The glance card was mouse-only. It now opens on focus, links itself to the focused element via aria-describedby and closes on Escape without moving focus (WCAG 1.4.13).
Preview DeploymentPreview deployments for this PR are available at:
The preview environment will start automatically on first visit. Subsequent pushes to this PR will update the Run locally with Dockerdocker pull ghcr.io/go-vikunja/vikunja:pr-3566
docker run -p 3456:3456 ghcr.io/go-vikunja/vikunja:pr-3566Last updated for commit a4f092f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task glance card (
TaskGlanceTooltip) was mouse-only:mouseenter/mouseleavehandlers, no focus path, no Escape, noaria-describedby. Keyboard and AT users got none of the glance info. Follow-up from #3544 review (flagged by the a11y pass there).Now: opens on focus of the wrapped link (same delay), sets
aria-describedbyon the focused element while visible, Escape dismisses without moving focus (stops propagation + preventDefault only when it actually closed the tooltip, so a surrounding<dialog>stays open), hover behaviour unchanged. Teleport no longer gated on the hover media query — thecanHovercheck moved into the mouse handler, so keyboard focus works on touch devices too. Still not hoverable (pointer-events: none) — out of scope.How to verify
aria-describedbypointing at the card's id.Before this PR: focusing a title showed nothing; only hover worked.