fix(link share): don't leak Bulma content margins into shared views - #3608
Merged
Conversation
…roject view ContentLinkShare wraps the router view in a `Card`, which defaults to `hasContent: true` and therefore adds Bulma's `.content` class around the whole project view. Logged-in views render without that wrapper, so the shared views picked up typography margins the normal views never had. The Kanban board is built from nested `ul`/`li` for buckets and tasks, so `.content ul` (2rem inline start, 1em top), `.content ul ul` and `.content li + li` all leaked in and shifted the board. Pass `:has-content="false"`, matching what ProjectList, ProjectTable and ProjectGantt already do on their own cards — those were ineffective for link shares because the outer card re-introduced `.content` around them. Fixes #3584
github-actions
Bot
added
area/kanban
Preview DeploymentPreview deployments for this PR are available at:
The preview environment will start automatically on first visit. Subsequent pushes to this PR will update the Run locally with Dockerdocker pull ghcr.io/go-vikunja/vikunja:pr-3608
docker run -p 3456:3456 ghcr.io/go-vikunja/vikunja:pr-3608Last updated for commit 9744e13 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shared project views render inside a
Cardthat defaults tohasContent: true, so Bulma's.contenttypography wrapped the whole view. Logged-in views have no such wrapper, so shared views — Kanban most visibly, since its buckets and tasks are nestedul/li— picked up.content ul,.content ul uland.content li + limargins that don't belong there.Fixes #3584
How to verify