fix(frontend): don't read attachment name after delete modal closes - #3737
Merged
Conversation
kolaente
approved these changes
Sep 4, 2026
kolaente
enabled auto-merge (rebase)
September 4, 2026 21:01
Preview DeploymentPreview deployments for this PR are available at:
The preview environment will start automatically on first visit. Subsequent pushes to this PR will update the Run locally with Dockerdocker pull ghcr.io/go-vikunja/vikunja:pr-3737
docker run -p 3456:3456 ghcr.io/go-vikunja/vikunja:pr-3737Last updated for commit c5523d4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attachment delete modal read
attachmentToDelete.file.nameunguarded in#textslot.Modal.vuekeep<dialog>and slot mounted through 150ms close transition, so slot re-render aftersetAttachmentToDelete(null)and throwTypeError: Cannot read properties of null (reading 'file'). Sentry FRONTEND-OSS-2AY, ~212 events.Fix:
v-if="attachmentToDelete"on the<p>. Text unchanged.Modal.vueuntouched. Unit test cover close-during-transition path.How to verify
Before this PR:
TypeError: Cannot read properties of null (reading 'file')was thrown during the fade-out.