fix(frontend): cache attachment blob urls across components - #3739
Open
tink-bot wants to merge 4 commits into
Open
fix(frontend): cache attachment blob urls across components#3739tink-bot wants to merge 4 commits into
tink-bot wants to merge 4 commits into
Conversation
Attachment blob urls were fetched per component instance with no caching or deduplication, so a task with many attachments issued one request per attachment per consumer.
github-actions
Bot
added
area/attachments
Preview DeploymentPreview deployments for this PR are available at:
The preview environment will start automatically on first visit. Subsequent pushes to this PR will update the Run locally with Dockerdocker pull ghcr.io/go-vikunja/vikunja:pr-3739
docker run -p 3456:3456 ghcr.io/go-vikunja/vikunja:pr-3739Last updated for commit e2f5b62 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every component fetch own attachment blob. No cache, no dedupe. Task detail with 19 attachments = 57 requests, ~33s cumulative (Sentry
FRONTEND-OSS-1TP, "N+1 API Call"): 19x preview?preview_size=md, plus 38x full original — every original pulled twice, because description editor and comment editor each keep own in-flight map (inFlightBlobFetches) and ownloadedAttachmentsrecord.Now one module-level cache in
frontend/src/helpers/attachments.ts, keyedtaskId-attachmentId-size, with in-flight promise map for dedupe. Same shape asfetchAvatarBlobUrl. Rejected fetch drop pending entry, so retry work. Cached urls shared — no consumer revoke them;clearAttachmentBlobCache()do that.Switched:
FilePreview.vue,KanbanCard.vuecover image, editor inline images. Untouched, on purpose:AudioPreview.vue,Attachments.vuepreview modal,attachmentService.download()— those own their blob and revoke it (unmount, decode error, modal close, download-to-disk), so shared cache would poison it.How to verify
/api/v1/tasks/:id/attachments/:id.