Skip to content

Make IsResumeGameAfterPluginLoad work with DllInject#1671

Open
marzent wants to merge 1 commit into
goatcorp:masterfrom
marzent:dll-wait
Open

Make IsResumeGameAfterPluginLoad work with DllInject#1671
marzent wants to merge 1 commit into
goatcorp:masterfrom
marzent:dll-wait

Conversation

@marzent

@marzent marzent commented Feb 19, 2024

Copy link
Copy Markdown
Contributor

This contains only the part of #1668 that makes DllInject block correctly on startup instead of silently failing to do so.

@marzent marzent requested a review from a team as a code owner February 19, 2024 18:22
@furfy

furfy commented Apr 1, 2024

Copy link
Copy Markdown

Tried it together with my friend on Arch Linux, compiled with the latest commit, with Penumbra mods, and for some reason they can't catch up on few initial game startups. Pre-caching or indexing maybe?
But now everything works great!

@KazWolfe KazWolfe self-assigned this Jun 3, 2024
@KazWolfe KazWolfe added core Dalamud core oh no Proof that making sand think was a mistake. labels Mar 26, 2025
@KazWolfe

KazWolfe commented Jan 3, 2026

Copy link
Copy Markdown
Member

@marzent Is this still applicable?

@marzent

marzent commented Jan 4, 2026

Copy link
Copy Markdown
Contributor Author

In general yes, but it will need a rebase...

When this PR was originally made DllInject was also the only useable option on wine, so it would have been more "nice" back then.

Before putting work into this it would be good to know if ignoring IsResumeGameAfterPluginLoad with DllInject is actually seen as a big enough issue and if this PR is wanted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Dalamud core oh no Proof that making sand think was a mistake.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants