Skip to content

Make color struct human readable#2559

Open
Glorou wants to merge 3 commits into
goatcorp:masterfrom
Glorou:ImGuizmoBindings
Open

Make color struct human readable#2559
Glorou wants to merge 3 commits into
goatcorp:masterfrom
Glorou:ImGuizmoBindings

Conversation

@Glorou

@Glorou Glorou commented Dec 29, 2025

Copy link
Copy Markdown
Contributor

This is to support goatcorp/gc-cimguizmo#1 with human readable color structs, I haven't verified them all yet but these are 1:1 with the C structs

@Glorou Glorou requested a review from a team as a code owner December 29, 2025 22:36
@goaaats

goaaats commented Jan 10, 2026

Copy link
Copy Markdown
Member

Did you generate this? Would it not be generated by the bindings generator?

@Glorou

Glorou commented Jan 10, 2026

Copy link
Copy Markdown
Contributor Author

I generated and then edited it. When generated, it will output the color names as Color0-Color14, so I modified the struct to line up with the original color definitions.

@Critical-Impact

Copy link
Copy Markdown
Member

Is there a way we can alter the generator to do this instead of having to do it by hand each time?

@Glorou

Glorou commented Feb 15, 2026

Copy link
Copy Markdown
Contributor Author

Is there a way we can alter the generator to do this instead of having to do it by hand each time?

With respect to this, the custom generated partial struct will override the generator, and so long as these variables dont change on the imguizmo side (they havent), they wont need to be re-generated. I recompiled just to triple check as well.

@Glorou

Glorou commented May 9, 2026

Copy link
Copy Markdown
Contributor Author

Hey @goaaats, saw you merged the other PR so I wanted to bump this one too.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants