Skip to content

Fix multiline log filtering and rendering#2718

Open
niklasstich wants to merge 2 commits into
goatcorp:masterfrom
niklasstich:fix-multiline-logs
Open

Fix multiline log filtering and rendering#2718
niklasstich wants to merge 2 commits into
goatcorp:masterfrom
niklasstich:fix-multiline-logs

Conversation

@niklasstich

@niklasstich niklasstich commented Apr 18, 2026

Copy link
Copy Markdown
  • Renamed LogEntry to LogLine
  • Added LogEntry class, only exists to have a unique reference
  • LogLine has a reference to a LogEntry
  • When filtering LogLines, first group the LogLines by LogEntry, if any of the lines in the grouping match the condition, all the lines in the grouping are added to the filtered collection

@niklasstich niklasstich force-pushed the fix-multiline-logs branch from 3f8aa10 to 3ca1f26 Compare May 1, 2026 13:25
@niklasstich niklasstich marked this pull request as ready for review May 1, 2026 13:29
@niklasstich niklasstich requested a review from a team as a code owner May 1, 2026 13:29
@niklasstich

Copy link
Copy Markdown
Author

I would appreciate some help testing and possibly fixing this if issues arise, as I am developing on Linux and therefore the workflow is a little clunky, always having to wait 10 minutes on the pipeline before I can test 🫠.

@niklasstich niklasstich force-pushed the fix-multiline-logs branch from 3ca1f26 to 4cfadff Compare May 27, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant