Skip to content

Use Lock.Scope throughout the project#2839

Open
Haselnussbomber wants to merge 35 commits into
goatcorp:masterfrom
Haselnussbomber:lock
Open

Use Lock.Scope throughout the project#2839
Haselnussbomber wants to merge 35 commits into
goatcorp:masterfrom
Haselnussbomber:lock

Conversation

@Haselnussbomber

Copy link
Copy Markdown
Member

While a lock block on a Lock object is translated into an EnterScope call on compile, doing it explicitly feels cleaner and also uncovered that a couple locks were still on objects/Lists instead. Using lock on an object makes it use the legacy Monitor class, which has some overhead.

I suggest to review without whitespace changes. :)
Hope I didn't break anything. 😇

@Haselnussbomber

Copy link
Copy Markdown
Member Author

Rebased to fix merge conflicts. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant