Fix crash on null third repo URL#2846
Open
Aireil wants to merge 3 commits into
Open
Conversation
Member
Author
|
Removing it in the end! Hasel pointed out the issue of TextInput using it and we might as well get rid of it directly. |
Member
Author
|
Added the runtime null checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2844.
Unsure how that null even happens.
Should Dalamud fix it directly when loading the config by removing the null entry?I suppose leaving it in allows the user to tell there is an issue with a repo that was probably fine before. It shows as an error message in the installer and there is an empty entry in the settings.