Remove soft return types - #123496
Open
HolonProduction wants to merge 1 commit into
Open
Remove soft return types#123496HolonProduction wants to merge 1 commit into
HolonProduction wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem(s) does this PR solve?
The above PR did check for soft return types in places that were consistently effected by them.
This PR completely removes soft types from return types, this is more risky than the above change and is bound to change behavior of some warnings. I'd hope to get this in early for 4.9.
However everything effected by this PR was previously dependent on function order (see the timing explanation from #121322 (comment)), which is why I don't consider this an issue. In addition the soft type deduction was bugged anyway which makes those warning not very reliable in the first place (only taking the last return statement into consideration).
Additional information
Here's an example were behaviour changes:
However