Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
daa7dc9
Initial plan
Claude Apr 7, 2026
db31cdf
Add URL() method to Route for generating URLs with parameters
Claude Apr 7, 2026
26faa1d
fix: address review feedback on Route.URL() - deterministic lookup, c…
Copilot Apr 7, 2026
6b37d8d
fix: nil guard, deterministic case-insensitive fallback, mounted rout…
Copilot Apr 7, 2026
434c6f2
refactor: extract shared buildRouteURL helper, add deterministic fall…
Copilot Apr 7, 2026
9fef978
fix: refine Route.URL greedy fallback and docs
Copilot Apr 7, 2026
be74496
test: cover default greedy fallback path
Copilot Apr 7, 2026
6d6740e
perf: avoid greedy fallback slice allocations
Copilot Apr 7, 2026
6e56f99
docs: clarify greedy fallback helper behavior
Copilot Apr 7, 2026
2e241ed
docs: explain Route.URL fallback edge cases
Copilot Apr 7, 2026
a7f3f1f
perf: precompute greedy fallback map keys
Copilot Apr 8, 2026
9b47da0
refactor: rename default greedy fallback keys
Copilot Apr 8, 2026
389a0f6
🐛 fix: make Route.URL callable on GetRoute values
Copilot Apr 8, 2026
3384a5b
🧹 chore: clarify Route.URL nolint rationale
Copilot Apr 8, 2026
afc8c17
🧹 chore: fix Route.URL comment casing
Copilot Apr 8, 2026
5ac4c3f
Merge branch 'main' into claude/fix-getroute-path-param
gaby Apr 10, 2026
3c20541
Merge branch 'main' into claude/fix-getroute-path-param
ReneWerner87 Apr 11, 2026
a44230b
Merge branch 'main' into claude/fix-getroute-path-param
gaby Apr 11, 2026
55afb07
Update res.go
gaby Apr 11, 2026
9f828e7
Update router.go
gaby Apr 11, 2026
77044e2
🐛 fix deterministic case-insensitive Route.URL key selection
Copilot Apr 11, 2026
f817947
Merge branch 'main' into claude/fix-getroute-path-param
gaby Apr 13, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ctx_interface_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions res_interface_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

46 changes: 46 additions & 0 deletions router.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,14 @@
package fiber

import (
"bytes"
"fmt"
"slices"
"sync/atomic"

"github.com/gofiber/utils/v2"
utilsstrings "github.com/gofiber/utils/v2/strings"
"github.com/valyala/bytebufferpool"
"github.com/valyala/fasthttp"
)

Expand Down Expand Up @@ -65,6 +67,50 @@ type Route struct {
autoHead bool // Automatically generated HEAD route
}

// URL generates a URL from the route path and parameters.
// This method fills in the route parameters with the provided values.
// Parameter matching is case-insensitive by default to match Fiber's default behavior.
//
// Example:
//
// app.Get("/user/:name/:id", handler).Name("user")
// route := app.GetRoute("user")
// url, err := route.URL(Map{"name": "john", "id": "123"})
// // Returns: "/user/john/123"
func (r *Route) URL(params Map) (string, error) {
if r.Path == "" {
Comment thread
gaby marked this conversation as resolved.
return "", ErrNotFound
}

Comment thread
gaby marked this conversation as resolved.
buf := bytebufferpool.Get()
defer bytebufferpool.Put(buf)

for _, segment := range r.routeParser.segs {
if !segment.IsParam {
_, err := buf.WriteString(segment.Const)
if err != nil {
return "", fmt.Errorf("failed to write string: %w", err)
}
continue
}

for key, val := range params {
// Use case-insensitive matching to support both CaseSensitive and non-CaseSensitive configs
isSame := key == segment.ParamName || utils.EqualFold(key, segment.ParamName)
isGreedy := segment.IsGreedy && len(key) == 1 && bytes.IndexByte(greedyParameters, key[0]) >= 0
Comment thread
gaby marked this conversation as resolved.
Outdated
if isSame || isGreedy {
_, err := buf.WriteString(utils.ToString(val))
if err != nil {
return "", fmt.Errorf("failed to write string: %w", err)
}
break
}
}
Comment thread
gaby marked this conversation as resolved.
Outdated
}

return buf.String(), nil
}

func (r *Route) match(detectionPath, path string, params *[maxParams]string) bool {
// root detectionPath check
if r.root && len(detectionPath) == 1 && detectionPath[0] == '/' {
Expand Down
133 changes: 133 additions & 0 deletions router_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2360,3 +2360,136 @@ func Benchmark_Router_GitHub_API_Parallel(b *testing.B) {
require.True(b, match)
}
}

// go test -run Test_Route_URL
func Test_Route_URL(t *testing.T) {
t.Parallel()

Comment thread
gaby marked this conversation as resolved.
t.Run("simple parameter", func(t *testing.T) {
t.Parallel()
app := New()
app.Get("/user/:name", emptyHandler).Name("User")

route := app.GetRoute("User")
url, err := route.URL(Map{"name": "fiber"})
require.NoError(t, err)
require.Equal(t, "/user/fiber", url)
})

t.Run("multiple parameters", func(t *testing.T) {
t.Parallel()
app := New()
app.Get("/user/:name/:id", emptyHandler).Name("UserID")

route := app.GetRoute("UserID")
url, err := route.URL(Map{"name": "john", "id": "123"})
require.NoError(t, err)
require.Equal(t, "/user/john/123", url)
})

t.Run("wildcard parameters", func(t *testing.T) {
t.Parallel()
app := New()
app.Get("/:phone/*/send/*", emptyHandler).Name("SendSms")

route := app.GetRoute("SendSms")
url, err := route.URL(Map{
"phone": "23456789",
"*1": "sms",
"*2": "test-msg",
})
require.NoError(t, err)
require.Equal(t, "/23456789/sms/send/test-msg", url)
})

t.Run("single wildcard parameter", func(t *testing.T) {
t.Parallel()
app := New()
app.Get("/:phone/*/send", emptyHandler).Name("SendSms")

route := app.GetRoute("SendSms")
url, err := route.URL(Map{
"phone": "23456789",
"*": "sms",
})
require.NoError(t, err)
require.Equal(t, "/23456789/sms/send", url)
})

t.Run("case sensitivity", func(t *testing.T) {
t.Parallel()
app := New()
app.Get("/user/:name", emptyHandler).Name("User")

Comment thread
gaby marked this conversation as resolved.
Outdated
route := app.GetRoute("User")
// Case-insensitive by default (matching Fiber's default behavior)
url, err := route.URL(Map{"Name": "fiber"})
require.NoError(t, err)
require.Equal(t, "/user/fiber", url)
Comment thread
gaby marked this conversation as resolved.
})

t.Run("empty route", func(t *testing.T) {
t.Parallel()
route := Route{}
url, err := route.URL(Map{"name": "fiber"})
require.Error(t, err)
require.Equal(t, ErrNotFound, err)
require.Empty(t, url)
})

t.Run("no parameters", func(t *testing.T) {
t.Parallel()
app := New()
app.Get("/static/path", emptyHandler).Name("Static")

route := app.GetRoute("Static")
url, err := route.URL(Map{})
require.NoError(t, err)
require.Equal(t, "/static/path", url)
})

t.Run("missing parameter value", func(t *testing.T) {
t.Parallel()
app := New()
app.Get("/user/:name/:id", emptyHandler).Name("UserID")

route := app.GetRoute("UserID")
url, err := route.URL(Map{"name": "john"})
require.NoError(t, err)
// Missing id parameter results in empty placeholder
require.Equal(t, "/user/john/", url)
})

t.Run("extra parameters ignored", func(t *testing.T) {
t.Parallel()
app := New()
app.Get("/user/:name", emptyHandler).Name("User")

route := app.GetRoute("User")
url, err := route.URL(Map{"name": "fiber", "extra": "ignored"})
require.NoError(t, err)
require.Equal(t, "/user/fiber", url)
})

t.Run("numeric parameter values", func(t *testing.T) {
t.Parallel()
app := New()
app.Get("/item/:id", emptyHandler).Name("Item")

route := app.GetRoute("Item")
url, err := route.URL(Map{"id": 42})
require.NoError(t, err)
require.Equal(t, "/item/42", url)
})

t.Run("complex path with mixed content", func(t *testing.T) {
t.Parallel()
app := New()
app.Get("/api/v1/users/:userId/posts/:postId/comments", emptyHandler).Name("Comments")

route := app.GetRoute("Comments")
url, err := route.URL(Map{"userId": "user123", "postId": "post456"})
require.NoError(t, err)
require.Equal(t, "/api/v1/users/user123/posts/post456/comments", url)
})
}
Loading