Skip to content

fix: fix typos in timeout middleware test comments#4516

Closed
maxtaran2010 wants to merge 1 commit into
gofiber:mainfrom
maxtaran2010:fix/typo-cancelation-in-timeout-tests
Closed

fix: fix typos in timeout middleware test comments#4516
maxtaran2010 wants to merge 1 commit into
gofiber:mainfrom
maxtaran2010:fix/typo-cancelation-in-timeout-tests

Conversation

@maxtaran2010

Copy link
Copy Markdown

Fix misspelling of "cancelation" (should be "cancellation") in three comments within the timeout middleware test file.

  • middleware/timeout/timeout_test.go:66: "context cancelation" -> "context cancellation"
  • middleware/timeout/timeout_test.go:81: "context cancelation" -> "context cancellation"
  • middleware/timeout/timeout_test.go:85: "detect cancelation" -> "detect cancellation"

Fix misspelling of "cancelation" -> "cancellation" in three
comments within middleware/timeout/timeout_test.go.

Signed-off-by: maxtaran2010 <ocotifuzo727@gmail.com>
Copilot AI review requested due to automatic review settings July 9, 2026 20:55
@maxtaran2010
maxtaran2010 requested a review from a team as a code owner July 9, 2026 20:55
@welcome

welcome Bot commented Jul 9, 2026

Copy link
Copy Markdown

Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@ReneWerner87 ReneWerner87 added this to v3 Jul 9, 2026
@ReneWerner87 ReneWerner87 added this to the v3 milestone Jul 9, 2026
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: aeaf553c-08d4-42c9-bedd-6f1e78f9b7ca

📥 Commits

Reviewing files that changed from the base of the PR and between c6f4afb and 2e89aa8.

📒 Files selected for processing (1)
  • middleware/timeout/timeout_test.go

Walkthrough

Corrects the spelling of “cancelation” to “cancellation” in timeout test comments and an assertion message. Test logic and control flow remain unchanged.

Changes

Timeout test wording

Layer / File(s) Summary
Correct timeout test spelling
middleware/timeout/timeout_test.go
Updates timeout test comments and the assertion message from “cancelation” to “cancellation”.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested labels: 📒 Documentation

Suggested reviewers: gaby, sixcolors, efectn

Poem

I’m a rabbit with a watch,
Hopping past each timeout notch.
“Cancellation” now spells just right,
The tests still race through day and night.
Squeak, the wording’s bright!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description summarizes the change but omits the required template sections like Fixes #, changes introduced, type of change, and checklist. Expand the PR description to match the template: add Fixes #, a Changes introduced list, type of change, and the checklist items.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the PR as a typo fix in timeout middleware test comments.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ReneWerner87

Copy link
Copy Markdown
Member

We use US spelling not UK in programming code and comments

@github-project-automation github-project-automation Bot moved this to Done in v3 Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants