feat!: remove TCP socket support for server connections#2527
Merged
joelim-work merged 2 commits intogokcehan:masterfrom Apr 16, 2026
Merged
feat!: remove TCP socket support for server connections#2527joelim-work merged 2 commits intogokcehan:masterfrom
joelim-work merged 2 commits intogokcehan:masterfrom
Conversation
Collaborator
CatsDeservePets
left a comment
There was a problem hiding this comment.
Don't get me wrong but I don't want to merge a PR you can't test yourself.
Contributor
Author
|
I was hoping someone with Windows at hands may be willing to test it first :) |
joelim-work
reviewed
Apr 15, 2026
Collaborator
joelim-work
left a comment
There was a problem hiding this comment.
You don't need any of the socket code anymore since you are assuming that support for unix sockets exists, just set gDefaultSocketPath as how it is done in os.go.
Additionally gSocketProt is going to always just be unix now, so you can also cleanup some of the surrounding code:
- Delete
gDefaultSocketProt - Set
gSocketProttounixdirectly, removing the variable altogether and hardcodingunixis also probably fine - Remove any if statements that depend on the value of
gSocketProt
joelim-work
approved these changes
Apr 16, 2026
Collaborator
joelim-work
left a comment
There was a problem hiding this comment.
Looks good, thanks for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since windows 10 (1803) the OS supports unix sockets
Older systems that dont have them would fall back to tcp sockets for the lf server client connection, which then listens to localhost, where the lf server can be reached by all local users, allowing access to the actual users files and shell (in theory, I dont have windows for testing)
Fortunately this should no longer be an issue on supported windows systems, but its probably better to just remove the fallback