cmd/go: honor -fullpath for compiler diagnostics#78552
cmd/go: honor -fullpath for compiler diagnostics#78552amirHdev wants to merge 1 commit intogolang:masterfrom
Conversation
|
This PR (HEAD: 0129f51) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/762961. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/762961. |
|
Message from Michael Matloob: Patch Set 1: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/762961. |
|
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2026-04-06T19:25:10Z","revision":"63dac143291979c3400cd4fd803c0cf99587f54c"} Please don’t reply on this GitHub thread. Visit golang.org/cl/762961. |
|
Message from Michael Matloob: Patch Set 1: -Commit-Queue (Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_10033>) Please don’t reply on this GitHub thread. Visit golang.org/cl/762961. |
|
Message from Go LUCI: Patch Set 1: This CL has failed the run. Reason: Tryjob golang/try/gotip-windows-amd64-longtest has failed with summary (view all results):
To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/762961. |
|
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/762961. |
|
Message from Michael Matloob: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/762961. |
Promote -fullpath into shared cmd/go build flag handling so it affects cmd/go error formatting as well as forwarded test-binary output. When -fullpath is set, avoid shortening file names in command output and package-load errors. Add script coverage for compiler diagnostics with 'go test -C ... -fullpath'. Fixes golang#60451 Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
0129f51 to
5682ad9
Compare
|
This PR (HEAD: 5682ad9) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/762961. Important tips:
|
Promote -fullpath into shared cmd/go build flag handling so it affects
cmd/go error formatting as well as forwarded test binary output.
When -fullpath is set avoid shortening file names in command output
and package-load errors. add script coverage for compiler diagnostics
with "go test -C ... -fullpath".
Fixes #60451