net/http: use consistent IDNA processing for dial target and Host header - #80446
Open
kingljl wants to merge 5 commits into
Open
net/http: use consistent IDNA processing for dial target and Host header#80446kingljl wants to merge 5 commits into
kingljl wants to merge 5 commits into
Conversation
Add IDNA ASCII processing for host in HTTP requests.
Add test for IDNA mapping in Transport layer
Updated IDNA processing to use idna.Lookup.ToASCII for host conversion, ensuring consistency with net/http.
Added IDNA processing for host strings to ensure consistency with the :authority header and prevent SSRF bypass.
Add IDNA processing for host in request headers to ensure consistency with dialed address, addressing potential SSRF filter bypass. A temporary commit has been made to make the function operational, and a pull request (PR) for the net library has already been submitted
Contributor
|
This PR (HEAD: 7f0bd51) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/802080. Important tips:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Host header instead of httpguts.PunycodeHostPort.
for the HTTP/2 :authority in EncodeHeaders (bundled copy).
in the vendored source of the bundle (see net/http: use consistent IDNA processing for dial target and Host header net#253).
idna.Lookup.ToASCII so the h2 connection-pool key matches the dial and
header.
HTTP/1 and HTTP/2.
For golang/net#253
Fixes #80417