http2: skip synctest.Wait in testers using a real connection - #265
http2: skip synctest.Wait in testers using a real connection#265Jefftree wants to merge 1 commit into
Conversation
Benchmarks using a real connection are not in a synctest bubble, so greet panicked. Fixes golang/go#81399
|
This PR (HEAD: b733579) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/net/+/829584. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/829584. |
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/829584. |
|
Closing. From go1.27 the implementation lives in net/http/internal/http2, which does not carry these benchmarks, so this only applies to older builds. |
Benchmarks using a real connection are not in a synctest bubble, so greet panicked.
Fixes golang/go#81399