Skip to content

Add biome 2.5.8 - #600

Open
agent-137 wants to merge 2 commits into
mainfrom
add-biome
Open

Add biome 2.5.8#600
agent-137 wants to merge 2 commits into
mainfrom
add-biome

Conversation

@agent-137

@agent-137 agent-137 commented Aug 12, 2026

Copy link
Copy Markdown
Member

Adds a package for Biome 2.5.8, the JS/TS/JSON/CSS formatter and linter.

  • Built from the source tarball (tag @biomejs/biome@2.5.8) with the packaged Rust 1.97.1 toolchain (satisfies upstream's 1.96.1 requirement).
  • make is in build_deps because tikv-jemalloc-sys's build script shells out to it.
  • Uses upstream's release profile as-is, including fat LTO. Note: the fat-LTO link of the final binary needs a lot of memory — it OOMed a smaller build sandbox before the sandbox memory was increased.
  • min package patched-build biome succeeds and min check --packages biome passes all checkers, including the post-build ones (enumerate bins, missing runtime_deps, standalone biome --version smoketest).

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Added Biome version 2.5.8 to the available build packages.
    • Included the Biome command-line tool for formatting and linting workflows.
    • Added support for installing and running Biome through the packaged command-line executable.
    • Added version verification to help ensure the packaged tool runs correctly.
    • Included licensing and source information for the new package.

Biome (biomejs/biome) formatter/linter for JS/TS/JSON/CSS, built from
source with the packaged Rust toolchain. Uses thin LTO instead of
upstream's fat LTO so the final link fits in build-sandbox memory.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6b31a548-7f99-43d5-91ab-0eef0bf65d85

📥 Commits

Reviewing files that changed from the base of the PR and between a93aba6 and 5326eca.

📒 Files selected for processing (1)
  • packages/biome/build.sh
💤 Files with no reviewable changes (1)
  • packages/biome/build.sh

📝 Walkthrough

Walkthrough

Adds Biome 2.5.8 as a package. The build definition verifies the upstream source, declares dependencies and metadata, and runs a version smoketest. The build script compiles biome_cli and installs the binary.

Changes

Biome package

Layer / File(s) Summary
Build and package Biome
packages/biome/build.ncl, packages/biome/build.sh
The package definition fetches and verifies Biome 2.5.8, declares build settings and metadata, maps the biome binary, and adds a version smoketest. The build script configures GCC and Rust flags, compiles biome_cli in release mode, and installs the binary.

Estimated code review effort: 2 (Simple) | ~15 minutes

Sequence Diagram(s)

sequenceDiagram
  participant BuildSystem
  participant BiomeBuildDefinition
  participant BiomeBuildScript
  participant BiomeSource
  BuildSystem->>BiomeBuildDefinition: resolve and verify Biome 2.5.8 source
  BiomeBuildDefinition->>BiomeBuildScript: run build.sh
  BiomeBuildScript->>BiomeSource: compile biome_cli
  BiomeBuildScript->>BuildSystem: install biome binary
  BuildSystem->>BuildSystem: run biome --version smoketest
Loading

Possibly related PRs

  • gominimal/pkgs#371: Adds a similar single-binary Rust CLI package build with reproducible Cargo settings.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: adding the Biome 2.5.8 package.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add-biome

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
packages/biome/build.sh (1)

12-12: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick win

Pin Cargo dependency resolution.

Add --locked to packages/biome/build.sh#L12. Cargo.lock pins the dependency graph, but it does not provide crate sources.

Keep needs.internet in packages/biome/build.ncl unless the fetch pipeline stages all registry sources for this package.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/biome/build.sh` at line 12, Pin Cargo dependency resolution in the
build command by adding the --locked flag to cargo build in
packages/biome/build.sh lines 12-12. Keep needs.internet unchanged in
packages/biome/build.ncl lines 39-41 unless the fetch pipeline is updated to
stage all registry sources for this package.

Sources: Coding guidelines, Learnings

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@packages/biome/build.sh`:
- Line 12: Pin Cargo dependency resolution in the build command by adding the
--locked flag to cargo build in packages/biome/build.sh lines 12-12. Keep
needs.internet unchanged in packages/biome/build.ncl lines 39-41 unless the
fetch pipeline is updated to stage all registry sources for this package.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3a751803-3e5f-485b-b3ea-eb8d4925c2f3

📥 Commits

Reviewing files that changed from the base of the PR and between fa95453 and a93aba6.

📒 Files selected for processing (2)
  • packages/biome/build.ncl
  • packages/biome/build.sh

The build sandbox now has enough memory for the fat-LTO link, so drop
the thin-LTO override and match upstream's release profile.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants