Conversation
Biome (biomejs/biome) formatter/linter for JS/TS/JSON/CSS, built from source with the packaged Rust toolchain. Uses thin LTO instead of upstream's fat LTO so the final link fits in build-sandbox memory. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughAdds Biome 2.5.8 as a package. The build definition verifies the upstream source, declares dependencies and metadata, and runs a version smoketest. The build script compiles ChangesBiome package
Estimated code review effort: 2 (Simple) | ~15 minutes Sequence Diagram(s)sequenceDiagram
participant BuildSystem
participant BiomeBuildDefinition
participant BiomeBuildScript
participant BiomeSource
BuildSystem->>BiomeBuildDefinition: resolve and verify Biome 2.5.8 source
BiomeBuildDefinition->>BiomeBuildScript: run build.sh
BiomeBuildScript->>BiomeSource: compile biome_cli
BiomeBuildScript->>BuildSystem: install biome binary
BuildSystem->>BuildSystem: run biome --version smoketest
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/biome/build.sh (1)
12-12: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winPin Cargo dependency resolution.
Add
--lockedtopackages/biome/build.sh#L12.Cargo.lockpins the dependency graph, but it does not provide crate sources.Keep
needs.internetinpackages/biome/build.nclunless the fetch pipeline stages all registry sources for this package.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/biome/build.sh` at line 12, Pin Cargo dependency resolution in the build command by adding the --locked flag to cargo build in packages/biome/build.sh lines 12-12. Keep needs.internet unchanged in packages/biome/build.ncl lines 39-41 unless the fetch pipeline is updated to stage all registry sources for this package.Sources: Coding guidelines, Learnings
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/biome/build.sh`:
- Line 12: Pin Cargo dependency resolution in the build command by adding the
--locked flag to cargo build in packages/biome/build.sh lines 12-12. Keep
needs.internet unchanged in packages/biome/build.ncl lines 39-41 unless the
fetch pipeline is updated to stage all registry sources for this package.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 3a751803-3e5f-485b-b3ea-eb8d4925c2f3
📒 Files selected for processing (2)
packages/biome/build.nclpackages/biome/build.sh
The build sandbox now has enough memory for the fat-LTO link, so drop the thin-LTO override and match upstream's release profile. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Adds a package for Biome 2.5.8, the JS/TS/JSON/CSS formatter and linter.
@biomejs/biome@2.5.8) with the packaged Rust 1.97.1 toolchain (satisfies upstream's 1.96.1 requirement).makeis inbuild_depsbecausetikv-jemalloc-sys's build script shells out to it.min package patched-build biomesucceeds andmin check --packages biomepasses all checkers, including the post-build ones (enumerate bins, missing runtime_deps, standalonebiome --versionsmoketest).🤖 Generated with Claude Code
Summary by CodeRabbit