Skip to content

Fix Recharts Tooltip labelFormatter TypeScript error #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dnlweijers wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Recharts Tooltip labelFormatter TypeScript error #66

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a36f86
Fix Recharts Tooltip labelFormatter TypeScript error
dnlweijers Jan 28, 2026
ec37fc1
Update client/src/components/ContactCard.tsx
dnlweijers Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 25 additions & 5 deletions client/src/components/ContactCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,17 +180,37 @@ export function ContactCard({
{/* Chart */}
<div className="bg-white p-6 rounded-xl shadow-sm border border-gray-200 h-[300px]">
<h5 className="text-sm font-medium text-gray-500 mb-4">RTT History & Threshold</h5>
<ResponsiveContainer width="100%" height="100%">
<ResponsiveContainer width="100%" height="100%">

Copilot AI Jan 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ResponsiveContainer has inconsistent indentation. It should be indented at the same level as the h5 element above it (line 182), which uses 28 spaces (7 levels of 4-space indentation). Currently, it's using 32 spaces (8 levels), making it inconsistent with the surrounding code structure.

Copilot uses AI. Check for mistakes.
<LineChart data={data}>
<CartesianGrid strokeDasharray="3 3" vertical={false} stroke="#f0f0f0" />
<XAxis dataKey="timestamp" hide />
<YAxis domain={['auto', 'auto']} />
<Tooltip
labelFormatter={(t: number) => new Date(t).toLocaleTimeString()}
contentStyle={{ borderRadius: '8px', border: 'none', boxShadow: '0 4px 6px -1px rgb(0 0 0 / 0.1)' }}
labelFormatter={(label) =>
typeof label === 'number'
? new Date(label).toLocaleTimeString()
: ''
}
contentStyle={{ borderRadius: '8px', border: 'none', boxShadow: '0 4px 6px -1px rgb(0 0 0 / 0.1)' }}
/>
<Line
type="monotone"
dataKey="avg"
stroke="#3b82f6"
strokeWidth={2}
dot={false}
name="Avg RTT"
isAnimationActive={false}
/>
<Line
type="step"
dataKey="threshold"
stroke="#ef4444"
strokeDasharray="5 5"
dot={false}
name="Threshold"
isAnimationActive={false}
/>
<Line type="monotone" dataKey="avg" stroke="#3b82f6" strokeWidth={2} dot={false} name="Avg RTT" isAnimationActive={false} />
<Line type="step" dataKey="threshold" stroke="#ef4444" strokeDasharray="5 5" dot={false} name="Threshold" isAnimationActive={false} />
</LineChart>
</ResponsiveContainer>
</div>
Expand Down