chore: scrub internal references from dashboard and starrocks profile#199
Open
rhefner1 wants to merge 1 commit into
Open
chore: scrub internal references from dashboard and starrocks profile#199rhefner1 wants to merge 1 commit into
rhefner1 wants to merge 1 commit into
Conversation
Remove GoodData-internal identifiers that don't belong in the public distribution: - starrocks-size-prod-xl: drop the provenance comment naming an internal cluster (pdx1), customer (ringcentral), employee, and Slack thread. The sizing spec it described is kept. - overall-health dashboard: reset the Cluster variable default from the internal "iad1" to All, the Namespace default from "tiger-ga" to this distribution's actual default namespace "gooddata-cn", narrow the namespace query to ".*gooddata.*", and drop the service-prefix legend line entirely (services have no uniform prefix - panels match container names like api-gw, calcique, sql-executor - so the claim was false). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
rhefner1
force-pushed
the
worktree-scrub-internal-comments
branch
from
1fc466e to
359e070
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes GoodData-internal identifiers that leaked into the public distribution's shipped files. No functional/sizing changes.
Changes
modules/k8s-common/templates/starrocks-size-prod-xl.yaml.tftplpdx1), customer (ringcentral), an employee, and a Slack thread. The sizing spec it described (3 CN nodes x 32 vCPU x 256 GiB…) is preserved.modules/k8s-common/dashboards/gooddata-cn-overall-health.json(shipped Grafana dashboard)Clustervariable defaultiad1→All($__all) — it's alabel_valuesquery var with includeAll, so this is the natural neutral default.Namespacevariable defaulttiger-ga→gooddata-cn(this repo's actual default namespace)..*tiger.*|.*gooddata.*|.*adhoc.*→.*gooddata.*, dropping internaltiger/adhocnamespace names.tiger-* … e.g. tiger-gateway = API Gateway) entirely. There is no uniform service prefix in this distribution — panels match raw container names likeapi-gw,gateway-api-gw,calcique,metadata-api,sql-executor— so the legend was simply false. The accurate component glossary (Calcique, Result Cache, SQL Executor, Pulsar, Export Builder, Hikari) is kept.Verification
terraform fmt -recursiveproduces no diff.ringcentral,pdx1,iad1,tiger-ga,tiger,adhoc,bohuslav,slack, …) returns zero remaining hits.🤖 Generated with Claude Code