feat(sizing): centralize size profiles across environments#200
Open
rhefner1 wants to merge 3 commits into
Open
feat(sizing): centralize size profiles across environments#200rhefner1 wants to merge 3 commits into
rhefner1 wants to merge 3 commits into
Conversation
Set allow_volume_expansion = true on both gp3 StorageClasses so PVCs can be grown in place without recreating the underlying volumes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Rewrite the size_profile guidance to explain that the profile sets sensible sizing defaults (metadata DB tier/storage, worker node sizes/counts, observability disk sizes, and GoodData.CN/subchart sizing) and drop the override lines that now default to the profile value. Standardize commented optional settings to a consistent "Uncomment to ..." convention across the aws, azure, and local examples so the intent of each commented block is unambiguous. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Move all per-profile sizing into a single size-profiles.tf per environment, resolved through locals: RDS/EKS on AWS, PostgreSQL/AKS on Azure, CNPG locally, plus the cloud-agnostic observability disk/memory and Tempo ingestion sizing in the shared module. Replace the size_profile input to the shared modules with explicit selectors (ingress_replicas, gdcn_size, pulsar_size, observability_size) and make the infrastructure override variables (eks/aks node sizing, rds/postgresql tier and storage) default to null so the chosen profile drives them unless explicitly overridden. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Centralizes deployment sizing behind the
size_profilevariable (dev/prod-small/prod-large) so a single setting drives metadata DB tier/storage, worker node sizes/counts, observability disk/memory/Tempo ingestion, ingress replicas, and GoodData.CN/subchart sizing across all three environments.Commits
allow_volume_expansion = trueon both gp3 StorageClasses so PVCs can grow in place.size_profileguidance, drops override lines that now default to the profile, and standardizes commented optional settings to a consistentUncomment to …convention across aws/azure/local.size-profiles.tfper environment (resolved via locals); replaces thesize_profileinput to the shared modules with explicit selectors (ingress_replicas,gdcn_size,pulsar_size,observability_size); makes infra override variables default tonullso the profile drives them unless explicitly overridden.Notes
The sizing change is atomic at the Terraform-graph level (variable-signature changes, locals relocation, and call-site rewiring must land together), so it is kept in one commit. The storage and docs changes are independent and split out.
terraform fmt -check -recursivepasses.🤖 Generated with Claude Code