Initialize int_sync and irq_flags in non DT use case.#6
Open
rrrh wants to merge 1 commit intogoodix:masterfrom
Open
Initialize int_sync and irq_flags in non DT use case.#6rrrh wants to merge 1 commit intogoodix:masterfrom
rrrh wants to merge 1 commit intogoodix:masterfrom
Conversation
rrrh
changed the title
rrrh
force-pushed
the
fix_pdata_for_non_dt
branch
from
3616ce6 to
12b9d61
Compare
Both fields need to be populated in the non device tree use case to make the touch controller work. When int_sync is not set to true, the initialization sequence is never finished by the host cpu and the controller remains in limbo. If the irq_flags are unassigned, falling edge triggered is assumed but the controller does rising edge triggered interrupts by default.
rrrh
force-pushed
the
fix_pdata_for_non_dt
branch
from
12b9d61 to
3de8183
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both fields need to be populated in the non device tree use case to make
the touch controller work.
When int_sync is not set to true,
the initialization sequence is never finished by the host cpu
and the controller remains in limbo.
If the irq_flags are unassigned, falling edge triggered is assumed but
the controller does rising edge triggered interrupts by default.