refactor(core): use centralized path resolution for Linux sandbox#24985
refactor(core): use centralized path resolution for Linux sandbox#24985
Conversation
|
Hi @ehedlund, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the Linux sandbox management by integrating a centralized path resolution mechanism. This change significantly simplifies the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
gemini-cli
bot
added
the
status/need-issue
|
Size Change: -1.62 kB (0%) Total Size: 34 MB
ℹ️ View Unchanged
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the bwrapArgsBuilder to use a resolvedPaths object, streamlining path handling within the sandbox. This change simplifies the BwrapArgsOptions interface and the buildBwrapArgs function by centralizing path resolution. Corresponding test files have been updated to reflect these new path management strategies, including the introduction of a createResolvedPaths helper. A review comment highlighted a potential regression in secret masking for symlinked workspaces, noting that the getSecretFilesArgs function should include both the original and resolved workspace paths to ensure comprehensive secret detection.
1 participant
Summary
Refactor the Linux sandbox management (
LinuxSandboxManagerandbuildBwrapArgs) to leverage the unifiedresolveSandboxPathsandResolvedSandboxPathsfromsandboxManager.ts. This change centralizes path resolution and symlink expansion, removing redundant and manual path handling from the Linux-specific implementation.Details
BwrapArgsOptionsto acceptResolvedSandboxPaths, mirroring the architecture used in the Windows sandbox.tryRealpathandsanitizePathscalls inbuildBwrapArgs, as these are now provided by the shared resolution service.Related Issues
Internal refactor.
How to Validate
npm test -w @google/gemini-cli-core -- src/sandbox/linux/bwrapArgsBuilder.test.tsnpm test -w @google/gemini-cli-core -- src/sandbox/linux/LinuxSandboxManager.test.tsPre-Merge Checklist