Conversation
|
Hi @jacob314, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a visual bug in the input prompt component where text was being clipped. By adjusting the width calculation to include space for the scrollbar, the component now correctly renders full-width input lines. Additionally, the ink library has been updated to the latest version, and new test coverage ensures this scenario is properly handled. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the ink dependency to version 6.6.9 and adjusts the InputPrompt component's width to accommodate a scrollbar, including a new test case for full-width lines. The review feedback highlights that package-lock.json contains extensive unrelated changes to peer dependencies that should be reverted by regenerating the lockfile in the recommended environment. Additionally, it is suggested to replace the magic number used for the width adjustment with a named constant to improve code maintainability.
| "license": "(Apache-2.0 AND BSD-3-Clause)", | ||
| "peer": true | ||
| "license": "(Apache-2.0 AND BSD-3-Clause)" | ||
| }, |
There was a problem hiding this comment.
The package-lock.json contains extensive unrelated changes, specifically the removal of the peer: true attribute across numerous dependencies. This typically indicates that the lockfile was updated using an incompatible version of npm or a different configuration than the project's standard. Please revert these changes and regenerate the lockfile using the recommended environment (Node.js ~20.19.0 and its bundled npm) to maintain lockfile consistency and avoid merge conflicts.
| : `ghost-${item.index}` | ||
| } | ||
| width={inputWidth} | ||
| width={inputWidth + 1 /* space for scrollbar */} |
There was a problem hiding this comment.
Adding a hardcoded + 1 to the width is a "magic number" fix. Magic numbers, especially those used for layout or padding, should be replaced with named constants to improve readability and maintainability. This makes the intent clearer and simplifies future updates.
References
- Magic numbers, especially those used for layout or padding, should be replaced with named constants to improve readability and maintainability.
There was a problem hiding this comment.
I think the comment suffices.
|
Size Change: +95 B (0%) Total Size: 34 MB
ℹ️ View Unchanged
|
gemini-cli
bot
added
the
priority/p1
| : `ghost-${item.index}` | ||
| } | ||
| width={inputWidth} | ||
| width={inputWidth + 1 /* space for scrollbar */} |
There was a problem hiding this comment.
I think the comment suffices.
2 participants
Summary
Details
Related Issues
How to Validate
Pre-Merge Checklist