Initial commit of the Substrate refactor#17
Merged
Conversation
…d conversation forking support
…erate the commit message for you.
Member
Author
|
@anj-s, see internal/controller2 for the refactoring. We need it for the Substrate refractor too. |
rakyll
changed the title
rakyll
force-pushed
the
substrate-scaffolding
branch
from
0a00a59 to
fc41076
Compare
anj-s
reviewed
May 22, 2026
anj-s
reviewed
May 22, 2026
anj-s
reviewed
May 22, 2026
| } | ||
| defer exec.Close(ctx) | ||
|
|
||
| if err := exec.Queue(ctx, req.Inputs...); err != nil { |
Collaborator
There was a problem hiding this comment.
Should queue be something that the controller owns Vs the execution interface which will be implemented by the user? I can see Run being the function that we want harness owners to implement but the queue, close, pause and resume are something will want to override from AX's side.
Member
Author
There was a problem hiding this comment.
It sounds like a follow up conversation for the Harness interface. We need to implement one concrete harness to figure out the right interface in my opinon.
anj-s
reviewed
May 22, 2026
…nt IDs to validation logic
Member
Author
|
PTAL |
anj-s
approved these changes
May 22, 2026
wjjclaud
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internal/controller2/: as a copy of the existing controller.internal/manifests/ax-deployment2.yaml.HarnessServiceto proto as a placeholder.internal/SUBSTRATE_REFACTOR_CLEANUPS.mdfor some cleanups after this refactor is done.SubstrateHarnessthat can create/resume axharness as an actor with conversation ID.Updates #3.