impl: gRPC server logging interceptors#68
Merged
Conversation
5 tasks
wjjclaud
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LoggingInterceptor): Captures and logs incoming unary RPC details, including full method names, duration, request success/failure, and dynamically extracts and includesconversation_idin log context if the request supportsGetConversationId().StreamLoggingInterceptor): Logs stream lifecycle events (start, complete, fail) along with latency, method names, and errors.server.go) and the harness server (server_harness.go) usinggrpc.ChainUnaryInterceptorandgrpc.ChainStreamInterceptor.bufconnto assert correct log formats, message contents, and error handling for both successful and failing unary/stream calls.Type of Change
Related Issues
Part 2 of the Observability & Monitoring epic.
Test Plan
conversation_idpropagation).Notes for Reviewer
This is the second of 5 planned modular PRs to roll out comprehensive AX observability. It introduces automatic logging for gRPC server entrypoints.