Allow delimiter defaults in optional JSDoc parameters - #4326
Draft
Pybsama wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Pybsama <294532706+Pybsama@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
]as the closing bracket, including empty defaults such as[name=]Root cause
The compatibility parser discarded a JSDoc Toolkit default value only when the lexer classified it as
STRING. Parentheses are emitted as distinct tokens, so the parser left them in place and then reported a falsemissing closing ]warning.Validation
bazelisk test //:test/com/google/javascript/jscomp/parsing/JsDocInfoParserTest --test_filter='JsDocInfoParserTest.testUnsupportedJsDocSyntax*'(OK (4 tests))bazelisk test //:test/com/google/javascript/jscomp/parsing/JsDocInfoParserTest(OK (780 tests))bazelisk test //:all(431 test targets passed)git diff --checkFixes #3767