Skip to content

Update ar.toml -Enhance Arabic User Experience with Feedback Labels and Correct Diacritics#2058

Merged
chalin merged 10 commits into
google:mainfrom
jadmadi:patch-2
Oct 1, 2024
Merged

Update ar.toml -Enhance Arabic User Experience with Feedback Labels and Correct Diacritics#2058
chalin merged 10 commits into
google:mainfrom
jadmadi:patch-2

Conversation

@jadmadi

@jadmadi jadmadi commented Jul 29, 2024

Copy link
Copy Markdown
Contributor

This pull request introduces Arabic feedback labels with accurate diacritics (Tashkeel) to improve the overall user experience for Arabic speakers.

Key changes:

  • Added Arabic strings for the "feedback" label.
  • Corrected and applied mandatory diacritics to Arabic characters.
  • Implemented the approved Arabic translation of "feedback" as defined by The Digital Arabic Language Hub (https://www.m-a-arabia.com/vb/showthread.php?t=30619).

This update ensures consistency with Arabic language standards and enhances the clarity and readability of the user interface for Arabic-speaking users.

jadmadi added 2 commits July 29, 2024 06:51
…critics and translation

Introduced strings for displaying "feedback" in the Arabic user interface.
Ensured proper mandatory diacritics (Tashkeel) are applied to Arabic characters for clarity.
Utilized the approved translation of "feedback" as provided by The Digital Arabic Language Hub (https://www.m-a-arabia.com/vb/showthread.php?t=30619).
Update ar.toml - Enhance Arabic User Experience with Feedback Labels and Correct Diacritics

@deining deining left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalin chalin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Please remove the extra spaces added throughout the file, since in the case of {{...}} directives, it will break the rendering.

Comment thread i18n/ar.toml Outdated
Comment thread i18n/ar.toml Outdated
Comment thread i18n/ar.toml Outdated
Comment thread i18n/ar.toml Outdated
@chalin chalin added this to the 24Q3 milestone Aug 5, 2024
@chalin chalin added the i18n Internationalization / Localization label Aug 5, 2024
jadmadi and others added 4 commits August 7, 2024 11:06
…critics and translation

Introduced strings for displaying "feedback" in the Arabic user interface.
Ensured proper mandatory diacritics (Tashkeel) are applied to Arabic characters for clarity.
Utilized the approved translation of "feedback" as provided by The Digital Arabic Language Hub (https://www.m-a-arabia.com/vb/showthread.php?t=30619).
@jadmadi jadmadi requested review from chalin and deining August 8, 2024 20:17

@chalin chalin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jadmadi

jadmadi commented Aug 11, 2024

Copy link
Copy Markdown
Contributor Author

@deining Would appreciate reviewing and approving it.

@deining deining left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jadmadi

jadmadi commented Aug 25, 2024

Copy link
Copy Markdown
Contributor Author

This is a stalled pull request. Should I tag someone, or is it just the regular procedure?

@chalin chalin merged commit 62df879 into google:main Oct 1, 2024
fekete-robert pushed a commit to fekete-robert/docsy that referenced this pull request May 30, 2025
…nd Correct Diacritics (google#2058)

Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Internationalization / Localization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants