systrap: preserve latency medians across histogram reset - #14431
Open
copybara-service[bot] wants to merge 1 commit into
Open
systrap: preserve latency medians across histogram reset#14431copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test/cl971361249
branch
3 times, most recently
from
August 26, 2026 20:24
405c759 to
1b478ea
Compare
sentryOnStubOn records the current stub- and sentry-bound latency medians, then resets both histograms before evaluating the two fast paths. The stub check correctly uses the saved values. The sentry check samples the now-empty histograms again, so it always receives zero and cannot account for the period that just ended. Use the saved period medians for the sentry check too. This matches the other state transitions and ensures both decisions are based on the same completed measurement period. Fixes: cffce1a ("systrap: Revise slow-path enablement.") Tested with: make test TARGETS='//pkg/sentry/platform/systrap:systrap_test' FUTURE_COPYBARA_INTEGRATE_REVIEW=#14426 from ayushr2:codex/fix-systrap-fastpath-median 6172a4b PiperOrigin-RevId: 971361249
copybara-service
Bot
force-pushed
the
test/cl971361249
branch
from
August 26, 2026 22:08
1b478ea to
ce8ba78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
systrap: preserve latency medians across histogram reset
sentryOnStubOn records the current stub- and sentry-bound latency medians,
then resets both histograms before evaluating the two fast paths. The stub
check correctly uses the saved values. The sentry check samples the now-empty
histograms again, so it always receives zero and cannot account for the
period that just ended.
Use the saved period medians for the sentry check too. This matches the
other state transitions and ensures both decisions are based on the same
completed measurement period.
Fixes: cffce1a ("systrap: Revise slow-path enablement.")
Tested with:
FUTURE_COPYBARA_INTEGRATE_REVIEW=#14426 from ayushr2:codex/fix-systrap-fastpath-median 6172a4b