Skip to content

Add support for definition list#306

Merged
qwandor merged 1 commit into
google:mainfrom
anonymaew:feat/def_list
May 28, 2026
Merged

Add support for definition list#306
qwandor merged 1 commit into
google:mainfrom
anonymaew:feat/def_list

Conversation

@anonymaew

Copy link
Copy Markdown
Contributor

This adds support for parsing and translating definition lists, which are used in markdown syntax like:

  Term 1

  : Definition 1

  Term 2

  : Definition 2a
  : Definition 2b

Changes

i18n-helpers/src/lib.rs

  • Added ENABLE_DEFINITION_LIST to the parser options in new_cmark_parser().
  • Added 3 test on definition list parsing

Result

Before After
rendered definition list before adjustment rendered definition list after adjustment

Add support for definition list by enabling the flag, that's all.

Also add couple of test on definition lists parsing.
@qwandor qwandor enabled auto-merge (squash) May 28, 2026 08:07
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.71%. Comparing base (9b96374) to head (a59a25c).
⚠️ Report is 44 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
- Coverage   86.05%   85.71%   -0.34%     
==========================================
  Files          17       17              
  Lines        3750     3374     -376     
  Branches     3750     3374     -376     
==========================================
- Hits         3227     2892     -335     
+ Misses        419      380      -39     
+ Partials      104      102       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@qwandor qwandor merged commit 760e499 into google:main May 28, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants