Skip to content

Fix JAX 64-bit precision mismatches by adding strict PriorDistribution dtype checks. #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
+547 −142
Open

Fix JAX 64-bit precision mismatches by adding strict PriorDistribution dtype checks. #1754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions meridian/model/prior_distribution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,6 +512,18 @@ class PriorDistribution:
)

def __post_init__(self):
if backend.float_dtype == np.float64:
for field in dataclasses.fields(self):
dist = getattr(self, field.name)
if dist is None:
continue
dist_dtype = getattr(dist, 'dtype', None)
if dist_dtype is not None and dist_dtype != np.float64:
raise ValueError(
f"Parameter '{field.name}' is expected to have dtype"
f' {backend.float_dtype}, but got {dist_dtype}.'
)

for param, bounds in _parameter_space_bounds.items():
prevent_deterministic_prior_at_bounds = (
_prevent_deterministic_prior_at_bounds[param]
Expand Down
Loading