WIP: perfetto reboot traces by KirillTim · Pull Request #3850 · google/perfetto

KirillTim · 2025-11-25T17:11:56Z

Tested:
atest CtsPerfettoReporterRebootTestCases
atest CtsPerfettoReporterTestCases

github-actions · 2025-11-25T17:19:43Z

🎨 Perfetto UI Build

✅ UI build is ready: https://storage.googleapis.com/perfetto-ci-artifacts/gh-20995970217-1-ui/ui/index.html

880e443 (2026-04-10 15:00 UTC): https://storage.googleapis.com/perfetto-ci-artifacts/gh-24249085153-1-ui/ui/index.html

…ub.com:google/perfetto into perfetto_recover_reboot_traces_9

…ot_traces_9 # Conflicts: # perfetto.rc

…APPING.

protos/perfetto/config/trace_config.proto

src/android_internal/tracing_service_proxy.cc

src/perfetto_cmd/perfetto_cmd.cc

…ot_traces_9 # Conflicts: # python/perfetto/protos/perfetto/trace/perfetto_trace_pb2.py # python/perfetto/protos/perfetto/trace/perfetto_trace_pb2.pyi # src/perfetto_cmd/perfetto_cmd.h # src/perfetto_cmd/perfetto_cmd_android.cc # test/cts/host_side_tests/src/android/perfetto/cts/test/PerfettoBootTimeTraceHostTest.java

…ot_traces_9

…ub.com:google/perfetto into perfetto_recover_reboot_traces_9

…ot_traces_9

…d number.

…ot_traces_9

primiano

as per offline discussion, let's keep this CL purely on the perfetto_cmd (and proto) changes.

let's split out the test and the .rc file, as I think i have a better proposal (Writing a doc now)

primiano · 2025-12-03T14:47:51Z

src/perfetto_cmd/perfetto_cmd.cc

+    persistent_trace_out_path_ = std::string(kAndroidPersistentStateDir) + "/" +
+                                 trace_config_->unique_session_name() +
+                                 ".pftrace";
+    PERFETTO_CHECK(trace_config_->output_path().empty());


THis should be an ELOG+return like the ones above

primiano · 2026-01-15T15:20:53Z

src/perfetto_cmd/perfetto_cmd.cc

+  --subscription-id     : ID of the subscription that triggered this trace.
+  --upload              : Upload trace.
+  --upload-after-reboot : Used by Android to upload the traces saved to a 
+                          special directory after the system reboot.


can you say: [Android-only] Reports to the Android framework all the traces marked as persist_trace_after_reboot=true which haven't been cleanly terminated.

primiano · 2026-01-15T15:23:59Z

src/perfetto_cmd/perfetto_cmd.cc

 #endif
    }
+    if (option == OPT_UPLOAD_AFTER_REBOOT) {
+#if PERFETTO_BUILDFLAG(PERFETTO_OS_ANDROID)


small thing. can you just set a boolean here, and move the logic below after the arg parsing?

I find a bit easier to reason about if the code here in the top does pure parsing and the logic happens below

primiano · 2026-01-15T15:25:25Z

src/perfetto_cmd/perfetto_cmd.cc

-      break;
-  }
+  statsd_logging_ = ShouldLogStatsdEvents(
+      *trace_config_, /*unspecified_filed_value=*/upload_flag_);


why this is called unspecified_field_value? call it upload_flag (also in the arg name)

primiano · 2026-01-15T15:25:41Z

src/perfetto_cmd/perfetto_cmd.cc


+// static
+bool PerfettoCmd::ShouldLogStatsdEvents(const TraceConfig& cfg,
+                                        bool unspecified_filed_value) {


s/unspecified_filed_value/upload_flag/ ?

primiano · 2026-01-15T16:12:25Z

src/perfetto_cmd/perfetto_cmd_android.cc

+  bool all_reports_succeed = true;
+  for (base::ScopedFile& fd : fds) {
+    std::optional<uint64_t> maybe_file_size = base::GetFileSize(*fd);
+    if (!maybe_file_size.has_value()) {


if (!maybe_file_size.has_value() || *maybe_file_size <= 0) {
PERFETTO_PLOG("Failed to stat persistent trace");
continue;
}
uint64_t file_size = maybe_file_size.value();

primiano · 2026-01-15T16:12:55Z

src/perfetto_cmd/perfetto_cmd_android.cc

+      continue;
+    }
+    uint64_t file_size = maybe_file_size.value();
+    if (maybe_file_size == 0) {


nit this should be file_size, i think the above is a cast of the bool operator actually (subtle bug i know). but if yuou follow my suggestion above this becomes more compact anyways.

primiano · 2026-01-15T16:15:01Z

src/perfetto_cmd/perfetto_cmd_android.cc

+      base::ScopedMmap mmaped_file =
+          base::ScopedMmap::FromHandle(std::move(mmap_fd), file_size);
+      if (!mmaped_file.IsValid()) {
+        continue;


PLOG failed to mmap

primiano · 2026-01-15T16:16:05Z

src/perfetto_cmd/perfetto_cmd_android.cc

+    }
+
+    if (!trace_config.has_value()) {
+      continue;


ELOG here (it shoul really never happen)

primiano · 2026-01-15T16:19:28Z

src/perfetto_cmd/perfetto_cmd_android.cc

+    return false;
+  }
+
+  bool all_reports_succeed = true;


i think rather than this, it's more error-proof to:

increment the counter of suceeded reports if you reach the end

then you return num_succeeded == fds_count (cache it at the beginning)

because here you are not accounting I think for weird cases like "the trace config could not be parsed" and so on

WIP add perfetto_cmd logic

c69fae3

KirillTim added 7 commits November 28, 2025 14:09

WIP add uploader logic and reboot host test.

b1be899

WIP add uploader logic and reboot host test.

df83b27

Merge branch 'dev/ktimofeev/perfetto_recover_reboot_traces_9' of gith…

b0646ba

…ub.com:google/perfetto into perfetto_recover_reboot_traces_9

Some changes in ReporterRebootTest.

57f3416

Merge remote-tracking branch 'origin/main' into perfetto_recover_rebo…

1816af5

…ot_traces_9 # Conflicts: # perfetto.rc

Fix PerfettoReporterRebootTest, write some code comments.

02415b9

Add check to make sure only init can use "--upload-after-reboot".

396e2d8

KirillTim changed the title ~~WIP: perfetto reboot traces: add perfetto_cmd logic and some tests~~ WIP: perfetto reboot traces Dec 2, 2025

KirillTim added 3 commits December 3, 2025 00:12

Rename perfetto.uploader_ready property, add new CTS test to TEST_M…

1c34fe6

…APPING.

Fix android.bp formatting

3415976

Uncomment target_preparer for the C++ CTS test.

86a8c38

primiano reviewed Dec 3, 2025

View reviewed changes

KirillTim added 12 commits December 3, 2025 15:29

Fix CtsPerfettoReporterTestCases

7c718bc

Fix PerfettoBootTimeTraceHostTest

b44c555

fix compilation after merge

21a9025

Get rid of persistent_trace_out_path_ field

d6e5cd4

Enable statsd logging when uploading traces on reboot

12c7815

Don't check uploader or traced props before reporting all traces.

6beb8b8

Don't keep upload_after_reboot_flag_, invoke function directly.

726723b

Delete leftover of upload_after_reboot_flag_.

baed6f6

Wrap mmap-ed file into a scope

c73f5c2

Wait for 'sys.boot_completed' in perfetto_cmd, not it 'ReportTrace'

e9f42bc

Cleanup ReportAllPersistentTracesToAndroidFramework

136de61

KirillTim requested a review from primiano January 9, 2026 16:54

KirillTim added 3 commits January 9, 2026 17:07

Remove outdated TODO comment.

279fc40

Remove useless log statements

7422634

Fix the proto documentation comment

ca2d65b

KirillTim added 13 commits January 12, 2026 12:56

Merge branch 'main' into dev/ktimofeev/perfetto_recover_reboot_traces_9

0e8991f

Rename the "perfetto.persistent.uploader.status" prop, add comments.

a33abfb

Merge branch 'main' into dev/ktimofeev/perfetto_recover_reboot_traces_9

cc09aa8

Merge remote-tracking branch 'origin/main' into perfetto_recover_rebo…

5d4fe60

…ot_traces_9

Merge branch 'dev/ktimofeev/perfetto_recover_reboot_traces_9' of gith…

365c361

…ub.com:google/perfetto into perfetto_recover_reboot_traces_9

Merge remote-tracking branch 'origin/main' into perfetto_recover_rebo…

2fae567

…ot_traces_9

Use no_clobber to not rewrite persistent trace, also new proto file…

e9f8ac7

…d number.

Merge remote-tracking branch 'origin/main' into perfetto_recover_rebo…

f7bc354

…ot_traces_9

misc fixes

638f920

Re-generate protos

e69d184

Fix cts tests to rely on a new --no-clobber behavior.

efb67da

Merge remote-tracking branch 'origin/main' into perfetto_recover_rebo…

e418b8f

…ot_traces_9

fix expected error message

555061e

primiano reviewed Jan 15, 2026

View reviewed changes

Merge branch 'main' into perfetto_recover_reboot_traces_9

89ef8d3

Conversation

KirillTim commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎨 Perfetto UI Build

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

primiano left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

KirillTim commented Nov 25, 2025 •

edited

Loading

github-actions bot commented Nov 25, 2025 •

edited

Loading