tp: add tree_propagate_down operator for tree transformations#5257
Merged
LalitMaganti merged 63 commits intomainfrom Apr 1, 2026
Merged
tp: add tree_propagate_down operator for tree transformations#5257LalitMaganti merged 63 commits intomainfrom
LalitMaganti merged 63 commits intomainfrom
Conversation
🎨 Perfetto UI Builds
|
LalitMaganti
force-pushed
the
dev/lalitm/tree-propagate-down
branch
from
e7a3b5d to
d3ea725
Compare
LalitMaganti
changed the base branch from
main
to
dev/lalitm/tree-columns-refactor
LalitMaganti
force-pushed
the
dev/lalitm/tree-columns-refactor
branch
from
8530a03 to
9dd318b
Compare
LalitMaganti
force-pushed
the
dev/lalitm/tree-propagate-down
branch
from
d3ea725 to
3e443d7
Compare
Add TreeColumns, a simple columnar storage type for tree data with a normalized parent array and dense null bitvectors. Add TreeColumnsBuilder which wraps RuntimeDataframeBuilder for type inference and null tracking, then converts the result to TreeColumns via a new BuildRaw() short-circuit on AdhocDataframeBuilder that returns raw FlexVectors + BitVectors without sort analysis, type downcasting, or Dataframe creation. TreeTransformer now takes TreeColumns instead of Dataframe, and TreeFromTable builds TreeColumns directly. This eliminates the need to destructure a Dataframe in the TreeTransformer constructor and provides a cleaner, tree-specific data representation.
Add a PropagateDown() method to TreeTransformer that propagates column values from root toward leaves via BFS. Each spec copies a source column into a new output column and applies an aggregate operation (SUM, MIN, MAX, FIRST, LAST) downward through the tree. Propagated columns become real columns in the transformer, so subsequent FilterTree() calls can reference them, enabling filter→propagate→filter chains. The PropagateTreeDown bytecode now takes spec_start/spec_count to process a contiguous range of specs, and each spec has separate source/dest column indices to support the copy-then-propagate pattern.
LalitMaganti
force-pushed
the
dev/lalitm/tree-columns-refactor
branch
from
9dd318b to
1566928
Compare
LalitMaganti
force-pushed
the
dev/lalitm/tree-propagate-down
branch
from
3e443d7 to
f76fd52
Compare
LalitMaganti
added a commit
that referenced
this pull request
Mar 30, 2026
## Summary - Add `TreeColumns`, a simple columnar storage type for tree data with normalized parent array and dense null bitvectors - Add `TreeColumnsBuilder` which wraps `RuntimeDataframeBuilder` for type inference/null tracking, then converts via a new `BuildRaw()` short-circuit that skips sort analysis, type downcasting, and Dataframe creation - `TreeTransformer` now takes `TreeColumns` instead of `Dataframe` ## Stack - **#5262 tp: introduce TreeColumns and refactor TreeTransformer to use it** (this PR) - #5257 tp: add tree_propagate_down operator for tree transformations ## Test plan - Existing tree filter diff tests pass (10 tests)
sashwinbalaji
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PropagateDown()method to TreeTransformer for root-to-leaf BFS propagationStack
Test plan