ui: Improve UX of com.android.AndroidLockContention#5392
Draft
ivan-chong wants to merge 1 commit intomainfrom
Draft
ui: Improve UX of com.android.AndroidLockContention#5392ivan-chong wants to merge 1 commit intomainfrom
ivan-chong wants to merge 1 commit intomainfrom
Conversation
🎨 Perfetto UI Builds
|
ivan-chong
force-pushed
the
dev/ivankc/lock-contention-ux
branch
2 times, most recently
from
607692a to
98b1668
Compare
This CL improves the UX of navigation by creating custom tracks above each blocking thread to mirror the lock contetion slices. These act as a visual indicator of where the contention is on the thread and allows the relevant contention details to ne displayed in the current selection tab. This also gives a target for arrows to be drawn between the two contention slices as a direct visual indicator of the relation. Bug: 289343169
ivan-chong
force-pushed
the
dev/ivankc/lock-contention-ux
branch
from
98b1668 to
5660ea7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL improves the UX of navigation by creating custom tracks above each blocking thread to mirror the lock contetion slices. These act as a visual indicator of where the contention is on the thread and allows the relevant contention details to be displayed in the current selection tab. This also gives a target for arrows to be drawn between the two contention slices as a direct visual indicator of the relation.
The navigation is now replaced with a single command which can be activated by 'Ctrl+[' to toggle.
Bug: 289343169