build: Only enable debug symbols for debug builds on non-Windows platforms#5411
Open
KananSu wants to merge 1 commit intogoogle:mainfrom
Open
build: Only enable debug symbols for debug builds on non-Windows platforms#5411KananSu wants to merge 1 commit intogoogle:mainfrom
KananSu wants to merge 1 commit intogoogle:mainfrom
Conversation
…forms The -g flag was unconditionally added to cflags for all non-Windows, non-WASM builds (Linux, macOS, etc.). This causes debug symbols to be generated even in release builds, unnecessarily increasing binary size and potentially impacting build performance. This change wraps the -g flag with a condition on `is_debug`, ensuring debug symbols are only generated when building in debug mode. Release builds (`is_debug = false`) will no longer include debug symbols by default.
Member
|
Sorry but this is WAI. We intentionally do this because we often test release builds locally and it's really nice to be able to have debug symbols for profiling and debugging issues. In release mode we have a step to strip binaries and if you want binaries without debug symbols you can use those stripped ones. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The -g flag was unconditionally added to cflags for all non-Windows, non-WASM builds (Linux, macOS, etc.). This causes debug symbols to be generated even in release builds, unnecessarily increasing binary size and potentially impacting build performance.
This change wraps the -g flag with a condition on
is_debug, ensuring debug symbols are only generated when building in debug mode. Release builds (is_debug = false) will no longer include debug symbols by default.