ui: Wattson: Optimize selection aggregators and track attribution#5427
Open
ui: Wattson: Optimize selection aggregators and track attribution#5427
Conversation
🎨 Perfetto UI Builds
|
Include the Android package UID in the internal idle transition attribution stages since the stdlib tables have it. This allows UI aggregators to group idle overhead by package without expensive joins against thread and process tables. Bug: 354290668 Signed-off-by: Samuel Wu <wusamuel@google.com>
Introduce internal aggregation macros that accept a pre-filtered task table. This provides the infrastructure for the UI to bypass expensive interval intersections on the full trace by passing in a smaller, time-filtered view of task estimates. Bug: 354290668 Signed-off-by: Samuel Wu <wusamuel@google.com>
Update Wattson UI to directly use newly added MACROS and tables. This reduces some work done by the UI and has more code and table reuse. There are a few screenshot diffs due to rounding errors (~0.01% diff). Bug: 354290668 Signed-off-by: Samuel Wu <wusamuel@google.com>
wusamuel6
force-pushed
the
dev/wusamuel/ui_consolidation
branch
from
470b0f2 to
e4d68b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate Wattson UI to directly use newly added MACROS and tables. This
reduces some work done by the UI and has more code and table reuse.
Bug: 354290668
Signed-off-by: Samuel Wu wusamuel@google.com