[yamlfmt] Change FileDiff to use bytes by default#295
Merged
braydonk merged 1 commit intogoogle:mainfrom Dec 2, 2025
Merged
Conversation
This PR adjusts `FileDiff.Original` and `FileDiff.Formatted` to use byte slice by default, and only do a string cast when requested. This path allows for scenarios where no diff comparison is done to avoid extra allocations. While it's fairly inconsequential, I also changed some spots where I printed a casted byte array to use `Printf` instead as it saves an allocation. Those were not hot paths (run once at the end) but I decided to change them anyway since I'm here anyway.
- fmt.Print(string(out))
+ os.Stdout.Write(out)It was better (no copy) |
Collaborator
Author
|
You can submit a PR for that if you'd like. I wasn't going to bother anyway since those are outputs run at the end of the program one time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #292
This PR adjusts
FileDiff.OriginalandFileDiff.Formattedto use byte slice by default, and only do a string cast when requested. This path allows for scenarios where no diff comparison is done to avoid extra allocations.While it's fairly inconsequential, I also changed some spots where I printed a casted byte array to use
Printfinstead as it saves an allocation. Those were not hot paths (run once at the end) but I decided to change them anyway since I'm here anyway.