-
Notifications
You must be signed in to change notification settings - Fork 132
impl(bigquery): add query errors #5873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+93
−5
Merged
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| // Copyright 2026 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // https://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| //! Custom errors for the Cloud BigQuery query client. | ||
|
|
||
| use google_cloud_bigquery_v2::model::ErrorProto; | ||
| use google_cloud_gax::error::Error; | ||
|
|
||
| /// Errors that can occur during query configuration, execution, or polling. | ||
| #[derive(thiserror::Error, Debug)] | ||
| #[non_exhaustive] | ||
| pub enum QueryError { | ||
| /// The project ID was not provided or could not be determined. | ||
| #[error("no project ID was provided")] | ||
| MissingProjectId, | ||
|
|
||
| /// Only query jobs are supported by this client. | ||
| #[error("only query jobs are supported")] | ||
| UnsupportedJobType, | ||
|
|
||
| /// The query job failed on the BigQuery service side. | ||
| /// Includes the list of error protocols returned by the service. | ||
| #[error("query job failed: {reason} - {message}")] | ||
| JobFailed { | ||
| /// The primary error reason code (e.g., "invalidQuery", "backendError"). | ||
| reason: String, | ||
| /// The error message. | ||
| message: String, | ||
| /// The list of all errors associated with the job. | ||
| errors: Vec<ErrorProto>, | ||
| }, | ||
|
|
||
| /// The underlying RPC failed. | ||
| #[non_exhaustive] | ||
| #[error("the operation failed. RPC error: {source}")] | ||
| Rpc { | ||
| /// The error returned by the service for the request. | ||
| #[source] | ||
| source: Error, | ||
| }, | ||
|
alvarowolfx marked this conversation as resolved.
|
||
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { | ||
| use super::*; | ||
|
|
||
| #[test] | ||
| fn test_job_failed_display() { | ||
| let err = QueryError::JobFailed { | ||
| reason: "invalidQuery".to_string(), | ||
| message: "Syntax error: Unexpected end of input".to_string(), | ||
| errors: vec![ | ||
| ErrorProto::new() | ||
| .set_reason("invalidQuery") | ||
| .set_message("Syntax error: Unexpected end of input"), | ||
| ], | ||
|
alvarowolfx marked this conversation as resolved.
Outdated
|
||
| }; | ||
| assert_eq!( | ||
| err.to_string(), | ||
| "query job failed: invalidQuery - Syntax error: Unexpected end of input" | ||
| ); | ||
| } | ||
|
|
||
| #[test] | ||
| fn test_rpc_display() { | ||
| let status = google_cloud_gax::error::rpc::Status::default() | ||
| .set_code(google_cloud_gax::error::rpc::Code::InvalidArgument) | ||
|
alvarowolfx marked this conversation as resolved.
Outdated
|
||
| .set_message("simulated bad request"); | ||
| let err = QueryError::Rpc { | ||
| source: Error::service(status), | ||
| }; | ||
| assert_eq!( | ||
| err.to_string(), | ||
| "the operation failed. RPC error: the service reports an error with code INVALID_ARGUMENT described as: simulated bad request" | ||
| ); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.