build: remove no-op preinstall script#1690
Open
everett1992 wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
The no-op preinstall script is a security risk and will cause friction for developers using npm v12, pnpm, and other npm clients that error on packages that define install script hooks. https://github.blog/changelog/2026-06-09-upcoming-breaking-changes-for-npm-v12/ https://pnpm.io/supply-chain-security#block-risky-postinstall-scripts I'm calling it a security risk, not because there's a vulnerability in @google/genai's preinstall script today, but because developers may thoughtlessly and needlessly approve @google/genai which opens the door if an attacker manages to compromise this repository and publish a malicious script. It adds friction too, when I updated by dependencies I was prompted to review and approve @google/genai's scripts. Which I denied, since it's just a no-op, but it took time out of my day. If I maintained a library I'd hesitate to production-depend on this package, or any package with a install script because I don't want my consumers to have to make the same choices.
everett1992
force-pushed
the
no-preinstall
branch
from
40dc70b to
a35693c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The no-op preinstall script is a security risk and will cause friction for developers using npm v12, pnpm, and other npm clients that error on packages that define install script hooks.
https://github.blog/changelog/2026-06-09-upcoming-breaking-changes-for-npm-v12/
https://pnpm.io/supply-chain-security#block-risky-postinstall-scripts
I'm calling it a security risk, not because there's a vulnerability in @google/genai's preinstall script today, but because developers may thoughtlessly and needlessly approve @google/genai which opens the door if an attacker manages to compromise this repository and publish a malicious script.
It adds friction too, when I updated by dependencies I was prompted to review and approve @google/genai's scripts. Which I denied, since it's just a no-op, but it took time out of my day. If I maintained a library I'd hesitate to production-depend on this package, or any package with a install script because I don't want my consumers to have to make the same choices.