fix: Don't set redundant Content-Length on file upload requests#1730
Open
elierotenberg wants to merge 1 commit into
Open
fix: Don't set redundant Content-Length on file upload requests#1730elierotenberg wants to merge 1 commit into
elierotenberg wants to merge 1 commit into
Conversation
Author
|
Note: I considered adding a test where we explicitly use an undici global dispatcher but this requires bumping undici and setting up a temporary http server (because spying on fetch would not use the global dispatcher) so I decided not to. I'm happy to do it if you wish though. |
fetch derives Content-Length from the request body. Setting it explicitly sent a duplicate header, which undici >= 7.26 rejects with UND_ERR_INVALID_ARG when a userland dispatcher is active. Fixes googleapis#1718
elierotenberg
force-pushed
the
fix-files-upload-content-length
branch
from
26c397c to
bdc41ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fetch derives Content-Length from the request body. Setting it explicitly sent a duplicate header, which undici >= 7.26 rejects with UND_ERR_INVALID_ARG when a userland dispatcher is active.
Fixes #1718