Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.

feat: add pipeline string expressions#2479

Merged
dlarocque merged 8 commits into
mainfrom
dl/string-expressions
Feb 27, 2026
Merged

feat: add pipeline string expressions#2479
dlarocque merged 8 commits into
mainfrom
dl/string-expressions

Conversation

@dlarocque

Copy link
Copy Markdown
Contributor

Adds the ltrim, rttrim, stringIndexOf, stringReplaceOne, stringReplaceAll, stringRepeat Pipeline expressions.

Adds the `ltrim`, `rttrim`, `stringIndexOf`, `stringReplaceOne`, `stringReplaceAll`, `stringRepeat` Pipeline expressions.
@dlarocque dlarocque requested review from a team February 6, 2026 16:34
@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Feb 6, 2026
Comment thread dev/src/pipelines/expression.ts
Comment thread dev/src/pipelines/expression.ts
Comment thread dev/system-test/pipeline.ts
Comment thread dev/system-test/pipeline.ts

@milaGGL milaGGL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add changelog for this pr as well

@dlarocque dlarocque left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@milaGGL I added some more test cases.

Where do I update the changelog? I didn't do that for my previous PR #2474

My understanding is that our tooling automatically sets the changelog entry to be the name and link of a PR

Comment thread dev/system-test/pipeline.ts
Comment thread dev/system-test/pipeline.ts
@dlarocque dlarocque requested a review from milaGGL February 11, 2026 15:23
@milaGGL

milaGGL commented Feb 11, 2026

Copy link
Copy Markdown
Contributor

Where do I update the changelog? I didn't do that for my previous PR #2474
My understanding is that our tooling automatically sets the changelog entry to be the name and link of a PR

I misremembered it. u r right, no need to manually update the CHANGELOG for this repo.

@dlarocque dlarocque assigned milaGGL and unassigned MarkDuckworth Feb 19, 2026
@dlarocque dlarocque requested a review from yvonnep165 February 24, 2026 16:49
@dlarocque dlarocque changed the title feat(firestore): add pipeline string expressions feat: add pipeline string expressions Feb 24, 2026
Comment thread dev/src/pipelines/expression.ts
Comment thread dev/src/pipelines/expression.ts Outdated
@dlarocque dlarocque requested a review from milaGGL February 25, 2026 15:11
@dlarocque dlarocque added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 25, 2026
* ```
*
* @param fieldName The name of the field containing the string or byte array.
* @param valueToTrim- Optional. A string or byte array containing the characters/bytes to trim.

@milaGGL milaGGL Feb 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

u might have missed this "-".
"npm run fix" should have fixed or complained about the format issue.

@milaGGL milaGGL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlarocque dlarocque requested a review from a team as a code owner February 26, 2026 16:43
@dlarocque dlarocque merged commit 1068f5c into main Feb 27, 2026
21 of 22 checks passed
@dlarocque dlarocque deleted the dl/string-expressions branch February 27, 2026 20:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: firestore Issues related to the googleapis/nodejs-firestore API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants