Remove phpunit deprecation warnings for prophesize#438
Closed
gitmathias wants to merge 3 commits intogoogleapis:mainfrom
Closed
Remove phpunit deprecation warnings for prophesize#438gitmathias wants to merge 3 commits intogoogleapis:mainfrom
gitmathias wants to merge 3 commits intogoogleapis:mainfrom
Conversation
Collaborator
|
The problem here is that we added back support for PHP 7.1 and 7.2, and phpunit prophecy 2.0 does not support those versions of PHP. There is a PR to add support for a polyfill (phpspec/prophecy-phpunit#38), so comment / +1 that if you'd like to see it added. |
Collaborator
|
This PR is now obsolete, as the changes have already been made in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seemed like it was only a factor in Firebase\JWT\CachedKeySetTest.
Could consider extending PHPUnit\Framework\TestCase to add the trait if plan on using the lib elsewhere.