Skip to content

Add translate anchors filter #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
simoncozens wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add translate anchors filter #514

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
afb06e4
Add translate anchors filter
simoncozens Jul 14, 2021
1637a0f
Sanity check before translating
simoncozens Jul 15, 2021
c3660cb
Use basefilter directly
simoncozens Jul 16, 2021
91688b0
Check for component use, fix sanity checks
simoncozens Jul 16, 2021
626701a
Downgrade warning to info
simoncozens Jul 16, 2021
cea39cb
Too stuff
simoncozens Jul 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Lib/ufo2ft/filters/optimizeAnchors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,14 @@ def filter(self, glyph):
# We're a base!
return False

# More sanity checks: skip over spacing marks
if glyph.width != 0:
return False
# Also skip over marks which are deliberately positioned over the
# previous glyphs
if glyph.getBounds().xMax < 0:

@anthrotype anthrotype Jul 16, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a heuristic as to guess whether a mark was "deliberately positioned over the previous glyph", I think this is a bit too fragile. It's conceivable that the xMax still be >= 0 while the mark being intentionally designed to fall on top of another (e.g. narrow) base glyph

return False

# We are a mark glyph with (at least) one attachment point.
theanchor = glyph.anchors[0]
self.context.matrix = Identity.translate(-theanchor.x, -theanchor.y)
Expand Down