fix: add location permission check and implement configuration fade#1058
Merged
Conversation
… configuration fade - Implement runtime location permission request using Compose rememberLauncherForActivityResult - Hide settings button after 5 seconds of inactivity to prevent map clutter
kikoso
changed the title
kikoso
reviewed
Mar 31, 2026
| distributionPath=wrapper/dists | ||
| distributionSha256Sum=a17ddd85a26b6a7f5ddb71ff8b05fc5104c0202c6e64782429790c933686c806 | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.1.0-bin.zip | ||
| distributionSha256Sum=b266d5ff6b90eada6dc3b20cb090e3731302e553a27c5d3e4df1f0d76beaff06 |
Collaborator
There was a problem hiding this comment.
Can we remove this from the PR?
kikoso
reviewed
Mar 31, 2026
kikoso
approved these changes
Mar 31, 2026
kikoso
left a comment
kikoso
left a comment
Collaborator
There was a problem hiding this comment.
I left a couple of comments, but besides that, it can be merged IMO
kikoso
reviewed
Mar 31, 2026
| distributionPath=wrapper/dists | ||
| distributionSha256Sum=b266d5ff6b90eada6dc3b20cb090e3731302e553a27c5d3e4df1f0d76beaff06 | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.3.1-bin.zip | ||
| distributionSha256Sum=a17ddd85a26b6a7f5ddb71ff8b05fc5104c0202c6e64782429790c933686c806 |
Collaborator
There was a problem hiding this comment.
I think we can totally remove this SHA.
Collaborator
Author
There was a problem hiding this comment.
Yep. I am also working a few other build issues.
For one, we have multiple copies of the same dependency in the toml file. I should have that resolved soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement runtime location permission request using Compose rememberLauncherForActivityResult. Hide settings button after 5 seconds of inactivity to prevent map clutter.