Skip to content

Skip DURATION setting if the query fails #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juansalazargenius wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Skip DURATION setting if the query fails #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
410c57c
[NS] Testing fix for the duration query
Mar 16, 2026
7ea1bed
[NS] Correcting issues
Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/lib/conversion/pid/query_handlers.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,11 @@ QUERY_HANDLER_SIGNATURE(duration)
g_autoptr(GstQuery) query = gst_query_new_duration(GST_FORMAT_TIME);
gboolean ret = gst_pad_peer_query(priv->self, query);
if (!ret) {
GST_ELEMENT_ERROR(
element, LIBRARY, FAILED, (NULL), ("Failed to query duration"));
return FALSE;
GST_WARNING("No segment event and duration query failed, "
"skipping duration property (possibly live source)");
return TRUE; // not an error, just skip setting duration
}

// Parse the duration
gint64 duration;
gst_query_parse_duration(query, NULL, &duration);
Expand Down