Conversation
sunker
changed the title
sunker
changed the title
sunker
force-pushed
the
eriksundell/codemod-messaging
branch
from
September 10, 2026 13:43
2d17ea5 to
0ab085c
Compare
sunker
changed the title
grafana-catalog-project-bot
Bot
moved this from 📬 Triage
to 🧑💻 In development
in Grafana Catalog Team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR streamlines how codemods talk to the author. They now record on the
Contextwithcontext.addNextStep()andcontext.skip(), and the framework renders it, instead of each codemod importingoutputand printing its own way. That fixesaddreporting a skip and a success at the same time, and puts next steps after the change list and the install rather than before them.Also updating the
experimental-app-sdkcodemod to align with this pattern.Which issue(s) this PR fixes:
Special notes for your reviewer:
Currently in
manager.ts, it bumps.cprc.jsonwhether or not a migration skipped, so a skipped migration is marked done permanently. Not sure this is the right path forward?