Conversation
@grafana/create-plugin
@grafana/eslint-config
@grafana/eslint-plugin-plugins
@grafana/plugin-docs-cli
@grafana/plugin-docs-parser
@grafana/plugin-e2e
@grafana/plugin-meta-extractor
@grafana/plugin-types-bundler
@grafana/react-detect
@grafana/sign-plugin
@grafana/tsconfig
commit: |
sunker
marked this pull request as ready for review
September 16, 2026 10:16
sunker
requested review from
academo,
andresmgot,
mckn and
oshirohugo
and removed request for
a team
September 16, 2026 10:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR makes runtime e2e-selectors the default in
@grafana/plugin-e2e, so tests resolve selectors from the Grafana under test rather than the bundled@grafana/e2e-selectorssnapshot. It is a no-op against Grafana below 13.3.0, which still falls back to the bundled selectors.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
If plugin-e2e can't resolve selectors from grafana 13.3+ where runtime selectors should be build assets, it will log an error in CI before falling back to bundled selectors.