Skip to content

feat(plugin-e2e): enable runtime e2e-selectors by default - #2886

Open
sunker wants to merge 2 commits into
mainfrom
sunker/plugin-e2e-runtime-selectors-default
Open

sunker wants to merge 2 commits into
mainfrom
sunker/plugin-e2e-runtime-selectors-default

Conversation

@sunker

@sunker sunker commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

This PR makes runtime e2e-selectors the default in @grafana/plugin-e2e, so tests resolve selectors from the Grafana under test rather than the bundled @grafana/e2e-selectors snapshot. It is a no-op against Grafana below 13.3.0, which still falls back to the bundled selectors.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

If plugin-e2e can't resolve selectors from grafana 13.3+ where runtime selectors should be build assets, it will log an error in CI before falling back to bundled selectors.

@sunker sunker added the preview Opts the PR into pkg.pr.new preview publishing label Sep 16, 2026
@pkg-pr-new

pkg-pr-new Bot commented Sep 16, 2026

Copy link
Copy Markdown

Open in StackBlitz

@grafana/create-plugin

npm i https://pkg.pr.new/grafana/plugin-tools/@grafana/create-plugin@ff52712 -D

@grafana/eslint-config

npm i https://pkg.pr.new/grafana/plugin-tools/@grafana/eslint-config@ff52712 -D

@grafana/eslint-plugin-plugins

npm i https://pkg.pr.new/grafana/plugin-tools/@grafana/eslint-plugin-plugins@ff52712 -D

@grafana/plugin-docs-cli

npm i https://pkg.pr.new/grafana/plugin-tools/@grafana/plugin-docs-cli@ff52712 -D

@grafana/plugin-docs-parser

npm i https://pkg.pr.new/grafana/plugin-tools/@grafana/plugin-docs-parser@ff52712 -D

@grafana/plugin-e2e

npm i https://pkg.pr.new/grafana/plugin-tools/@grafana/plugin-e2e@ff52712 -D

@grafana/plugin-meta-extractor

npm i https://pkg.pr.new/grafana/plugin-tools/@grafana/plugin-meta-extractor@ff52712 -D

@grafana/plugin-types-bundler

npm i https://pkg.pr.new/grafana/plugin-tools/@grafana/plugin-types-bundler@ff52712 -D

@grafana/react-detect

npm i https://pkg.pr.new/grafana/plugin-tools/@grafana/react-detect@ff52712 -D

@grafana/sign-plugin

npm i https://pkg.pr.new/grafana/plugin-tools/@grafana/sign-plugin@ff52712 -D

@grafana/tsconfig

npm i https://pkg.pr.new/grafana/plugin-tools/@grafana/tsconfig@ff52712 -D

commit: ff52712

@sunker
sunker marked this pull request as ready for review September 16, 2026 10:16
@sunker
sunker requested a review from a team as a code owner September 16, 2026 10:16
@sunker
sunker requested review from academo, andresmgot, mckn and oshirohugo and removed request for a team September 16, 2026 10:16
@grafana-catalog-project-bot grafana-catalog-project-bot Bot moved this from 📬 Triage to 🔬 In review in Grafana Catalog Team Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview Opts the PR into pkg.pr.new preview publishing

Projects

Status: 🔬 In review

Development

Successfully merging this pull request may close these issues.

1 participant