Skip to content

refactor(ci): improve workflows with centralized node version and github actions pinned to latest release versions #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mahula wants to merge 14 commits into
base: main
Choose a base branch
from
Open

refactor(ci): improve workflows with centralized node version and github actions pinned to latest release versions #1022

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
1c92da7
Improve GitHub Actions workflow: parallelize checks and use .nvmrc
mahula Mar 31, 2026
01edf82
Use .nvmrc for Node version in all workflows
mahula Mar 31, 2026
c75dbe0
Add coverage thresholds to prevent regression
mahula Mar 31, 2026
194da07
add names to testing workflow jobs
mahula Mar 31, 2026
b652fcb
pin commit hashes with version comment for checkout and setup-node ac…
mahula Mar 31, 2026
d4ba2ab
add npm ci to each job that needs node dependencies
mahula Mar 31, 2026
9820d9b
revert test step paralellization in testing workflow
mahula Apr 1, 2026
8318752
Merge branch 'gramps-project:main' into ci-improve-test-workflow
mahula Apr 7, 2026
eb3e924
Merge branch 'gramps-project:main' into ci-improve-test-workflow
mahula Apr 7, 2026
f6dcb65
set all github workflow actions to latest version
mahula Apr 7, 2026
3ceaebd
Merge branch 'gramps-project:main' into ci-improve-test-workflow
mahula Apr 7, 2026
b0bb953
update test coverage thresholds in vitest.config.js
mahula Apr 7, 2026
63a5dfe
remove coverage thresholds from vitest config
mahula Apr 9, 2026
d7576a2
Merge branch 'gramps-project:main' into ci-improve-test-workflow
mahula Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/image-devel.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: checkout code
uses: actions/checkout@v4
- uses: actions/setup-node@v4
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
with:
node-version: '22'
node-version-file: .nvmrc
Comment thread
mahula marked this conversation as resolved.
Outdated
- name: Install and Build
run: |
npm install
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/image-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: checkout code
uses: actions/checkout@v4
- uses: actions/setup-node@v4
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
with:
node-version: '22'
node-version-file: .nvmrc
Comment thread
mahula marked this conversation as resolved.
Outdated
- name: Install and Build
run: |
npm install
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ jobs:
deploy:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
with:
node-version: "22"
node-version-file: .nvmrc
Comment thread
mahula marked this conversation as resolved.
Outdated
- name: Install and Build
run: |
npm install
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,11 @@ jobs:
test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
with:
node-version: "22"
node-version-file: .nvmrc
cache: 'npm'
Comment thread
mahula marked this conversation as resolved.
Outdated
- name: Install
run: npm ci
- name: ESLint
Expand Down
1 change: 1 addition & 0 deletions .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
22
Comment thread
mahula marked this conversation as resolved.
7 changes: 7 additions & 0 deletions vitest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,13 @@ export default defineConfig({
provider: 'v8',
reporter: ['text', 'lcov'],
include: ['src/**/*.js'],
thresholds: {
statements: 1.73,
branches: 1.73,
functions: 0.88,
lines: 1.74,
failWhenThresholdNotMet: true,
},
},
},
})
Loading