Skip to content

Add Family member to Ancestor Tree#1040

Draft
jittymolmathew92 wants to merge 3 commits intogramps-project:mainfrom
jittymolmathew92:add-person-to-family-tree
Draft

Add Family member to Ancestor Tree#1040
jittymolmathew92 wants to merge 3 commits intogramps-project:mainfrom
jittymolmathew92:add-person-to-family-tree

Conversation

@jittymolmathew92
Copy link
Copy Markdown
Contributor

@jittymolmathew92 jittymolmathew92 commented Apr 4, 2026

The UI implementation for add new family member against a person is included in this PR.

There is no backend integration.

@jittymolmathew92 jittymolmathew92 changed the title Updated for UI changes Add Family member to Ancestor Tree Apr 4, 2026
@DavidMStraub DavidMStraub marked this pull request as draft April 5, 2026 10:30
Comment thread lang/en.json Outdated
Comment thread src/charts/TreeChart.js Outdated
Comment thread src/components/GrampsjsTreeChartAddPerson.js Outdated
@DavidMStraub
Copy link
Copy Markdown
Member

Some UX considerations:

  • the view needs an "edit mode" (with pencil FAB, blue app bar etc., like the object views) - plus signs should only displayed in tedit mode
  • We should not offer "father" and "mother" as options to people who already have father and mother. While people can have multiple parent families (when adopted etc.), this is not something that is unique enough to handle from a tree view.

Next, you can implement the backend logic. But this is too complicated to implement from scratch: it can all be done via firing edit:action events. The problem is that these events are currently handled in GrampjsViewObject, from which GrampsjsViewTreeChartBase does not inherit. So it's best to move this handling logic somewhere up in the stack (perhaps even GrampsJs.js) or into a mixing. I suggest to feed this comment as prompt to Claude and ask it to do a tradeoff analysis of possible architectures and recommend one.

@jittymolmathew92 jittymolmathew92 force-pushed the add-person-to-family-tree branch 2 times, most recently from 0144840 to fe8588a Compare April 8, 2026 19:07
@jittymolmathew92 jittymolmathew92 force-pushed the add-person-to-family-tree branch from fe8588a to 2cb292b Compare April 16, 2026 09:25
…button in tree node with popup by UI consideration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants