Fix: OpenAPI spec and scanner framework status codes#2269
Open
Kraemii wants to merge 1 commit into
Open
Conversation
Correct wrong status codes and sync the OpenAPI spec with
the scanner framework:
- return 409 Conflict (was 406) for duplicate scan IDs, actions on a
scan in the wrong state, and deleting a running scan
- reject malformed `range` query on GET /scans/{id}/results with 400
- notus: return 400 on package parse errors and a JSON body on 500
- document 401 (reusable Unauthorized response) on all authenticated
/scans endpoints
- document 503 on /health/alive and /health/started
- drop non-idiomatic responses from the spec
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct wrong status codes and sync the OpenAPI spec with the scanner framework:
rangequery on GET /scans/{id}/results with 400Jira: SC-1592